[webkit-reviews] review requested: [Bug 29803] QWebHistory autotest crash : [Attachment 40227] create mainframe if needed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 28 04:57:32 PDT 2009


jedrzej.nowacki at nokia.com has asked  for review:
Bug 29803: QWebHistory autotest crash
https://bugs.webkit.org/show_bug.cgi?id=29803

Attachment 40227: create mainframe if needed
https://bugs.webkit.org/attachment.cgi?id=40227&action=review

------- Additional Comments from jedrzej.nowacki at nokia.com
I'm not sure if it is the best solution. m_mainFrame can't be created in
QWebPage constructor (it should be a way to connect a frameCreated signal). 
In the patch, QWebPage::history() and QWebPage::currentFrame() call
QWebPagePrivate::createMainFrame() as a side effect. It is rather bad, why
history need a frame to work? Maybe it is better to modify WebCore::Page class
instead?


More information about the webkit-reviews mailing list