[webkit-reviews] review granted: [Bug 17429] Inspector should show event listeners/handlers registered on each node : [Attachment 40116] [PATCH] Event Listeners Version 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 27 13:20:22 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 17429: Inspector should show event listeners/handlers registered on each
node
https://bugs.webkit.org/show_bug.cgi?id=17429

Attachment 40116: [PATCH] Event Listeners Version 3
https://bugs.webkit.org/attachment.cgi?id=40116&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +    thisNode->eventAncestors(ancestors);

No need for "thisNode->".

You also need to add EventListenersSidebarPane.js to WebCore.vcproj.

See http://trac.webkit.org/changeset/48392#file3 for an example.

File a new bug to track improving the UI with ideas that have been mentioned so
far.


More information about the webkit-reviews mailing list