[webkit-reviews] review requested: [Bug 27693] Crash with DOM manipulation of <use> elements : [Attachment 40189] patch that fixes crash caused by using a symbol that doesn't exist

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 27 00:30:08 PDT 2009


Charles Wei <charles.wei at torchmobile.com.cn> has asked	for review:
Bug 27693: Crash with DOM manipulation of <use> elements
https://bugs.webkit.org/show_bug.cgi?id=27693

Attachment 40189: patch that fixes crash caused by using a symbol that doesn't
exist
https://bugs.webkit.org/attachment.cgi?id=40189&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
When a symbol that was referenced by a <use> does not exist,  the SVGUseElement
doesn't bother to build the instance tree and shadow tree in
SVGUseElement::buildPendingResource().	Thus in :

static bool shadowTreeContainsChangedNodes(SVGElementInstance* target)

we should first check if target exists,  if target is NULL, we just return
false.


More information about the webkit-reviews mailing list