[webkit-reviews] review requested: [Bug 27546] [GTK] context menu overriding API is very limited : [Attachment 40181] Conditionalize font menu item, omit spell check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 26 15:13:30 PDT 2009


Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 27546: [GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Attachment 40181: Conditionalize font menu item, omit spell check
https://bugs.webkit.org/attachment.cgi?id=40181&action=review

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
This patch changes the context menu in this way:

- "Web Search" is never shown in editables.
- "Font" is only shown if there is rich text editing.
- "Spell checking" is never shown.
I originally thought of conditionalizing it but now I think it's not useful
since it basically only provides options that belong in a Preferences dialogue.
At least that's what I found.


More information about the webkit-reviews mailing list