[webkit-reviews] review granted: [Bug 29764] mark-bug-fixed: add -o|--open switch : [Attachment 40169] Patch v1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 29764: mark-bug-fixed: add -o|--open switch
https://bugs.webkit.org/show_bug.cgi?id=29764

Attachment 40169: Patch v1
https://bugs.webkit.org/attachment.cgi?id=40169&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I like the feature!  But it's sad that it seems more of this should be in the
modules and thus shared between commands.

_prompt_user_for_correctness seems useful in logging.py.

_open_bug_in_web_browser I'm not sure.	Maybe bugzilla?  or some new desktop.py
or interaction.py?  I do wonder if other modules (like post-diff for instance)
would want to have this option.  This is one of the sad things about splitting
commands into separate scripts like this is that we have to be careful not to
end up with too much code duplication.

I'm glad to see this script becoming more useful for Apple though. :)