[webkit-reviews] review requested: [Bug 29664] [Chromium] Add initial V8 bindings for WebGL : [Attachment 40150] Revised patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 29664: [Chromium] Add initial V8 bindings for WebGL
https://bugs.webkit.org/show_bug.cgi?id=29664

Attachment 40150: Revised patch
https://bugs.webkit.org/attachment.cgi?id=40150&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Made above requested changes. Comments:

> > +	     } else {
> > +		 return throwError("Could not convert argument 0 to either an
int32 or an array");
> > +	     }
> 
> ditto.

Changed this, but I think leaving the braces off the trailing else clause is
ugly.

> > +	     OwnPtr<GraphicsContext3DInternal> d;
> 
> would love a slightly more descriptive name :)

Renamed to m_internal.