[webkit-reviews] review requested: [Bug 27895] [XSSAuditor] Inline Event Handler with single-line JavaScript comment can bypass XSSAuditor : [Attachment 40145] Patch with test cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 25 14:32:33 PDT 2009


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 27895: [XSSAuditor] Inline Event Handler with single-line JavaScript
comment can bypass XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27895

Attachment 40145: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=40145&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I went with a modified Proposed Patch 1. Instead of defining a new class
MappedAttributeWithRawCharacters and using static_casts, I moved the
functionality I needed into Attribute.h (i.e.
Attribute:rawAttributeBeforeValue() and
Attribute::setRawAttributeBeforeValue(const String& string)). Hence, there are
no static_casts in this patch.


More information about the webkit-reviews mailing list