[webkit-reviews] review granted: [Bug 29729] SQLiteTransaction should use BEGIN DEFERRED instead of BEGIN to begin read-only transactions : [Attachment 40098] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 29729: SQLiteTransaction should use BEGIN DEFERRED instead of BEGIN to
begin read-only transactions
https://bugs.webkit.org/show_bug.cgi?id=29729

Attachment 40098: patch
https://bugs.webkit.org/attachment.cgi?id=40098&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think it's fine to be explicit, assuming that "BEGIN" normally means "BEGIN
DEFERRED".  You need to answer Mark's question before we can commit this
though.

Also the ordering of the comments seems a bit odd. Maybe the two comments
should just be unified into one to explain both cases?	The links seem useful
for explaining both.

r+ but please consider the comment modifications, and make sure to answer
Mark's query before any commit.