[webkit-reviews] review requested: [Bug 29744] svn-unapply and svn-apply don't work when used outside multiple svn working directories : [Attachment 40130] Patch v1

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 29744: svn-unapply and svn-apply don't work when used outside multiple svn
working directories
https://bugs.webkit.org/show_bug.cgi?id=29744

Attachment 40130: Patch v1
https://bugs.webkit.org/attachment.cgi?id=40130&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Some users have a workflow where svn-create-patch, svn-apply and
svn-unapply are used outside of multiple svn working
directories.  Instead of aborting the scripts in these cases,
print a warning and assume that Subversion is being used.

* Scripts/VCSUtils.pm:
(determineVCSRoot): Call warn() instead of die() if both isGit()
and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
to enforce the assumption about Subversion, then return
determineSVNRoot().
* Scripts/svn-apply: Switch to using isGit() and isSVN() from
VCSUtils.pm.  They both already cache their values and checking
here is redundant since determineVCSRoot() is called later.
---
 3 files changed, 41 insertions(+), 19 deletions(-)