[webkit-reviews] review canceled: [Bug 29715] [All] RVCT compilation of WebKit fails due to ARM/Thumb defines in Platform.h : [Attachment 40104] Check RVCT macros for ARM_THUMB2 platform

[bugzilla-daemon at webkit.org]

Gabor Loki <loki at inf.u-szeged.hu> has canceled Gabor Loki
<loki at inf.u-szeged.hu>'s request for review:
Bug 29715: [All] RVCT compilation of WebKit fails due to ARM/Thumb defines in
Platform.h
https://bugs.webkit.org/show_bug.cgi?id=29715

Attachment 40104: Check RVCT macros for ARM_THUMB2 platform
https://bugs.webkit.org/attachment.cgi?id=40104&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
I have rewritten the whole ARM/Thumb detection according to comment #8 and
comment #17.

The detection of ARM_ARCH_VERSION is almost the same as it was, except
__TARGET_ARM_ARCH macro from RVCT. A new macro - THUMB_ARCH_VERSION - has been
introduced to detect Thumb-2 support. The detection mechanism is similar to the
ARM one. And finally the ARM_THUMB2 platform will be set if the compiler sets
'__thumb2__' macro or '__thumb__' one while THUMB_ARCH_VERSION is 4.