[webkit-reviews] review denied: [Bug 28970] content-type parameters not taken into account when building form-data : [Attachment 40117] proposed patch - 2009/09/25

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Patrick Mueller
<pmuellr at yahoo.com>'s request for review:
Bug 28970: content-type parameters not taken into account when building
form-data
https://bugs.webkit.org/show_bug.cgi?id=28970

Attachment 40117: proposed patch - 2009/09/25
https://bugs.webkit.org/attachment.cgi?id=40117&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Nice work! Just fix up these little things.

> +		   if (val.indexOf("%") >= 0)
> +		       try {
> +			   val = decodeURIComponent(val);
> +		       } catch(e) {
> +			   errorDecoding = true;
> +		       }

This should have braces around it since it is multiline.


> +		   val = val.replace(/\+/g, " ");
> +	       valEscaped = val.escapeHTML();

I know "val" isn't new, but it really should have not been abbrivated in the
first place per our style guide. Same goes for valEscaped.


> +		   valEscaped += " <span class=\"error-message\">" +
WebInspector.UIString("(unable to decode value)") + "</span>";

I think the UIString should have ".escapeHTML()" also, sicne the localization
could use HTML special characters.