[webkit-reviews] review requested: [Bug 17429] Inspector should show event listeners/handlers registered on each node : [Attachment 40116] [PATCH] Event Listeners Version 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 25 10:28:38 PDT 2009


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 17429: Inspector should show event listeners/handlers registered on each
node
https://bugs.webkit.org/show_bug.cgi?id=17429

Attachment 40116: [PATCH] Event Listeners Version 3
https://bugs.webkit.org/attachment.cgi?id=40116&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Changes:
- Removed the JavaScriptCore export of "calculatedDisplayName", use JavaScript
solution instead
- Added Gear Menu and Preference for Filtering Event Listeners (defaults to
all)
- Nicely display "No Event Listeners" when appropriate
- Uses the "(anonymous function)" UI String instead of my hardcoded string
- Factored out "appropriateSelectorForNode" into utilities.js used here an in
StylesSidebarPane


More information about the webkit-reviews mailing list