[webkit-reviews] review denied: [Bug 29664] [Chromium] Add initial V8 bindings for WebGL : [Attachment 40047] Revised patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Kenneth Russell
<kbr at google.com>'s request for review:
Bug 29664: [Chromium] Add initial V8 bindings for WebGL
https://bugs.webkit.org/show_bug.cgi?id=29664

Attachment 40047: Revised patch
https://bugs.webkit.org/attachment.cgi?id=40047&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
We're almost there!

> +	   if (argLen == 0) {
> +	       return throwError("No arguments specified to constructor");
> +	   }

no braces for one-liners.

> +	   } else {
> +	       return throwError("Could not convert argument 0 to either an
int32 or an array");
> +	   }

ditto.

> +    if (data == NULL) {

if (!data) {

> +    if (data == NULL) {

ditto.

> +    if (data == NULL) {

ditto.

> +	   OwnPtr<GraphicsContext3DInternal> d;

would love a slightly more descriptive name :)