[webkit-reviews] review denied: [Bug 29706] Qt: Allow excluding certain plugins from loading : [Attachment 40052] Qt patch to allow overriding plugin loading

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Marius Renn
<damarvy at gmail.com>'s request for review:
Bug 29706: Qt: Allow excluding certain plugins from loading
https://bugs.webkit.org/show_bug.cgi?id=29706

Attachment 40052: Qt patch to allow overriding plugin loading
https://bugs.webkit.org/attachment.cgi?id=40052&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I'm sorry, this doesn't look right.

QWebPluginDatabase has a private constructor and is a singleton accessed
through QWebSettings. It is not designed for
sub-classing, so adding virtual functions won't work.

Why is QWebPluginInfo's setEnabled not sufficient for your use-case?