[webkit-reviews] review requested: [Bug 29715] [All] RVCT compilation of WebKit fails due to ARM/Thumb defines in Platform.h : [Attachment 40103] Check RVCT macros as well for ARM_THUMB2 JIT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 25 03:16:23 PDT 2009


Gabor Loki <loki at inf.u-szeged.hu> has asked  for review:
Bug 29715: [All] RVCT compilation of WebKit fails due to ARM/Thumb defines in
Platform.h
https://bugs.webkit.org/show_bug.cgi?id=29715

Attachment 40103: Check RVCT macros as well for ARM_THUMB2 JIT
https://bugs.webkit.org/attachment.cgi?id=40103&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
This patch adds an additional check for ARM_THUMB2 platform when the compiler
is RVCT. The RVCT compiler does not defines 'thumb2' and/or '__thumb2__'. It
only defines 'thumb' and '__thumb__' macros in Thumb2 mode.

In addition, the ARMv6T2 cpu have to be in ARMv6 group.


More information about the webkit-reviews mailing list