[webkit-reviews] review requested: [Bug 29731] [Qt] [Api] Added a QWebFrame::load(QWebLoadRequest) method : [Attachment 40097] patch 0.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 24 20:18:09 PDT 2009


Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 29731: [Qt] [Api] Added a QWebFrame::load(QWebLoadRequest) method
https://bugs.webkit.org/show_bug.cgi?id=29731

Attachment 40097: patch 0.1
https://bugs.webkit.org/attachment.cgi?id=40097&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
Patch does:

* Add a QWebLoadRequest (not yet inheriting from QNetworkRequest - maybe no
need to).
* Add a QWebFrame::load method that take a QWebLoadRequest as parameter
* Adap QWebFrame's setHtml and setContent implementation to use
QWebLoadRequest.
* Make 'Substitution' load to not emit urlChanged.

i am requesting review to get comments, since i probably needs a api
discussion.


More information about the webkit-reviews mailing list