[webkit-reviews] review denied: [Bug 29715] [All] RVCT compilation of WebKit fails due to ARM/Thumb defines in Platform.h : [Attachment 40091] 2nd patch, independent of 1st.

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 29715: [All] RVCT compilation of WebKit fails due to ARM/Thumb defines in
Platform.h
https://bugs.webkit.org/show_bug.cgi?id=29715

Attachment 40091: 2nd patch, independent of 1st.
https://bugs.webkit.org/attachment.cgi?id=40091&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
It doesn't make a lot of sense to me to make the presence of the
traditional/thumb2 define dependent on the assembler, and this behaviour may be
confusing to any developer not expecting this.	I'd suggest something like:

/* Defines two pseudo-platforms for ARM and Thumb-2 instruction set. */
#if !defined(WTF_PLATFORM_ARM_TRADITIONAL) && !defined(WTF_PLATFORM_ARM_THUMB2)

    #if defined(thumb2) || defined(__thumb2__)
    #define WTF_PLATFORM_ARM_THUMB2 1
    #else
    #define WTF_PLATFORM_ARM_TRADITIONAL 1
    #endif
#endif // !defined(WTF_PLATFORM_ARM_TRADITIONAL) &&
!defined(WTF_PLATFORM_ARM_THUMB2)
/* Sanity Check */
#if PLATFORM(ARM_TRADITIONAL) == PLATFORM(ARM_THUMB2)
    #error "Must define *either* PLATFORM(ARM_TRADITIONAL) *or*
PLATFORM(ARM_THUMB2)."
#endif // PLATFORM(ARM_TRADITIONAL) == PLATFORM(ARM_THUMB2)