[webkit-reviews] review denied: [Bug 29723] Division is needlessly slow in 64-bit : [Attachment 40084] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 24 15:36:57 PDT 2009


Geoffrey Garen <ggaren at apple.com> has denied Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 29723: Division is needlessly slow in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=29723

Attachment 40084: Patch v1
https://bugs.webkit.org/attachment.cgi?id=40084&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
As I said on IRC, I think you should copy JSVALUE32_64, and convert back to int
at the end in all cases other than 1/x. See JITArithmetic.cpp:992.


More information about the webkit-reviews mailing list