[webkit-reviews] review requested: [Bug 17429] Inspector should show event listeners/handlers registered on each node : [Attachment 40082] [PATCH] Event Listeners Version 1

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 17429: Inspector should show event listeners/handlers registered on each
node
https://bugs.webkit.org/show_bug.cgi?id=17429

Attachment 40082: [PATCH] Event Listeners Version 1
https://bugs.webkit.org/attachment.cgi?id=40082&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Geoffrey Garen just made some impressive (and very clean) changes to
EventListeners, EventTargets, etc.  This is compatible with his changes!

Technical Notes and Questions:
- I made the InspectorFrontEnd's ScriptState available so I could construct a
particular ScriptObject directly (see
InspectorDOMAgent::buildObjectForEventListener). That was because I didn't want
to make a function passing a JSObject to the front end and leave v8 by the
wayside. Any ideas around this, is there something agnostic I can pass?
- I exported calculatedDisplayName for functions in JSC. I think I will end up
dropped this altogether and just taking a JavaScript approach at getting the
function name, since the calculated display name seems to provide no benefit,
even for anonymous functions. Are there any advantages to
calculatedDisplayName?

UI Notes:
- There was discussion today on IRC that the UI would change. The UI in this
patch reuses as much CSS as possible so that inner properties tree looks as you
would expect.  When we change the inner portion to a better UI those redundant
CSS properties can hopefully be dropped.
- Tim Hatcher suggested adding a Gear Menu to switch between just
EventListeners for the focused Node, and all EventListeners in the Event Flow.
This should come in a future version.