[webkit-reviews] review denied: [Bug 28054] use derefInNotNull function to work around winscw compiler bug regarding template arguments. : [Attachment 39298] fix build break in mac build.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 24 13:14:08 PDT 2009


Eric Seidel <eric at webkit.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 28054: use derefInNotNull function to work around winscw compiler bug
regarding template arguments.
https://bugs.webkit.org/show_bug.cgi?id=28054

Attachment 39298: fix build break in mac build.
https://bugs.webkit.org/attachment.cgi?id=39298&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This patch looks OK.  It would be better with references to the winscw bugs. 
You mention above that winscw might not be used for much longer?  We should
have bugs on file about rolling out these kind of hacks once winscw is no
longer used.

Have you filed a bug with the winscw team about this issue?  Will you please
add a link to said bug to the ChangeLog so someone looking at this later might
know if they can remove this hack?


More information about the webkit-reviews mailing list