[webkit-reviews] review denied: [Bug 29716] [GTK] re-enable some media tests : [Attachment 40071] proposed patch (without white spaces in ChangeLog)

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 29716: [GTK] re-enable some media tests
https://bugs.webkit.org/show_bug.cgi?id=29716

Attachment 40071: proposed patch (without white spaces in ChangeLog)
https://bugs.webkit.org/attachment.cgi?id=40071&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
OK, a couple nits:

> +	   [GTK] re-enable some media tests
> +	   https://bugs.webkit.org/show_bug.cgi?id=29716
> +
> +	   make canPlayType() return "probably" if mime-type is known
> +	   and codecs string is not empty. If codecs is empty return
> +	   "maybe".
> +	   * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
> +	   (WebCore::MediaPlayerPrivate::duration):
> +

This is refering to duration, but you only touch supportsType. Maybe it was
incorrectly generated by prepare-ChangeLogs, but may be worth fixing. Also, I
think you want a blank line between the message and the list of files. I'll ask
that you upload a new patch just because I am lazy and want to use the commit
bot =).