[webkit-reviews] review requested: [Bug 29639] [Qt] Update the stypeProperty API of QWebElement. : [Attachment 40058] Split patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 24 04:29:40 PDT 2009
Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked for review:
Bug 29639: [Qt] Update the stypeProperty API of QWebElement.
https://bugs.webkit.org/show_bug.cgi?id=29639
Attachment 40058: Split patch
https://bugs.webkit.org/attachment.cgi?id=40058&action=review
------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Yes this makes sense, I've split the patch in 3 including these two other bugs:
https://bugs.webkit.org/show_bug.cgi?id=29708
https://bugs.webkit.org/show_bug.cgi?id=29709
This patch now only contain the modifications about QWebElement::styleProperty:
(QWebElement::styleProperty):
- Merge the stypeProperty and the computedStyleProperty methods
- Remove the default value for the style resolving enum
- Rename ResolveRule to StyleResolveStrategy
(QWebElement::setStyleProperty):
- Remove the priority argument since it is possible to control the
behaviour by adding !important or removing in the value.
More information about the webkit-reviews
mailing list