[webkit-reviews] review denied: [Bug 29005] The values of RuntimeArray are not enumerable : [Attachment 39685] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 24 03:57:24 PDT 2009


Oliver Hunt <oliver at apple.com> has denied  review:
Bug 29005: The values of RuntimeArray are not enumerable
https://bugs.webkit.org/show_bug.cgi?id=29005

Attachment 39685: proposed patch
https://bugs.webkit.org/attachment.cgi?id=39685&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
It is incorrect to override getPropertyNames in almost any case.  You should be
overriding getOwnPropertyNames.


More information about the webkit-reviews mailing list