[webkit-reviews] review requested: [Bug 29706] Qt: Allow excluding certain plugins from loading : [Attachment 40052] Qt patch to allow overriding plugin loading

[bugzilla-daemon at webkit.org]

Marius Renn <damarvy at gmail.com> has asked  for review:
Bug 29706: Qt: Allow excluding certain plugins from loading
https://bugs.webkit.org/show_bug.cgi?id=29706

Attachment 40052: Qt patch to allow overriding plugin loading
https://bugs.webkit.org/attachment.cgi?id=40052&action=review

------- Additional Comments from Marius Renn <damarvy at gmail.com>
I have extended the plugin load delegation functionality described in bug 28677
(https://bugs.webkit.org/show_bug.cgi?id=28677) to the Qt API layer, where I
have added two virtual methods shouldLoadPluginAtPath() and
shouldLoadPluginWithInfo() to the QWebPluginDatabase class. These allow
subclasses to make decisions on which plugins to load without altering the
plugin directory. As plugins may execute code when they are loaded, it may be
desirable to exclude certain plugins which are known to cause problems with the
client application. While the default implementation of these two additional
methods simply returns true, a subclass may do something more sophisticated
(such as excluding certain plugins).