[webkit-reviews] review requested: [Bug 29004] [HTML5][Forms] simple implementation of date&time types of INPUT element : [Attachment 40036] Patch part 1: recognize date&time types as text fields (rev.2)

[bugzilla-daemon at webkit.org]

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 29004: [HTML5][Forms] simple implementation of date&time types of INPUT
element
https://bugs.webkit.org/show_bug.cgi?id=29004

Attachment 40036: Patch part 1: recognize date&time types as text fields
(rev.2)
https://bugs.webkit.org/attachment.cgi?id=40036&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
> Explicit String construction isn't needed:
> String("button")

Fixed.

> Why two lookups?

Fixed.

> Lets make a hash for these too:
> @@ const AtomicString& HTMLInputElement::formControlType() const

Done.  I used Vector.


> Default is bad with switches over enums:
>     default:

Removed the default label and expanded the rest of types.