[webkit-reviews] review granted: [Bug 29634] Introduce Pasteboard::writePlaintext(const String&) for copying elements code to clipboard in WebInspector : [Attachment 39989] patch (explanation in ChangeLog, fixed style for wx)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 23 17:35:46 PDT 2009


Eric Seidel <eric at webkit.org> has granted apavlov at chromium.org's request for
review:
Bug 29634: Introduce Pasteboard::writePlaintext(const String&) for copying
elements code to clipboard in WebInspector
https://bugs.webkit.org/show_bug.cgi?id=29634

Attachment 39989: patch (explanation in ChangeLog, fixed style for wx)
https://bugs.webkit.org/attachment.cgi?id=39989&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  Looks sane enough.  We don't generally commit commented-out code, but I
can understand the difficulties here with the chromium stuff being split
between two repositories.  If you wanted this auto-committed by the bot, you'll
need to set commit-queue=?.  Otherwise you can find someone to commit this for
you since I don't think you're a committer yet (at least I don't remember that
being the case).


More information about the webkit-reviews mailing list