[webkit-reviews] review denied: [Bug 27029] [Qt] Allow custom memory allocation control in the whole JSCore : [Attachment 39982] proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 27029: [Qt] Allow custom memory allocation control in the whole JSCore
https://bugs.webkit.org/show_bug.cgi?id=27029

Attachment 39982: proposed patch
https://bugs.webkit.org/attachment.cgi?id=39982&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why does this not just blow out the stack?

+static void sleep(unsigned seconds)
+{
+    sleep(seconds * 1000);
+}

Is one of them in WTF?	If so, then the other should use :: to make it explicit
that it's a root namespace call.

Also the sleep call seems unrelated to the rest of the patch, or at least is
not explained in the ChangeLog.

diff likes newlines at end of files:
+DEFINES+=USE_SYSTEM_MALLOC
\ No newline at end of file
(so does GCC)