[webkit-reviews] review requested: [Bug 28868] [HTML5][Forms] :valid/:invalid/:optional/:required CSS selectors should be applied lively : [Attachment 40029] Proposed patch (rev.4)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 23 16:39:55 PDT 2009


TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 28868: [HTML5][Forms] :valid/:invalid/:optional/:required CSS selectors
should be applied lively
https://bugs.webkit.org/show_bug.cgi?id=28868

Attachment 40029: Proposed patch (rev.4)
https://bugs.webkit.org/attachment.cgi?id=40029&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>

> Needs {} since the comment makes it multi-line.  There are 2 instances of
that.

Fixed 2 instances, and removed {} for single statement at another place.

> If updateValue() isn't const anymore, why is this const_cast needed?
>  297	   const_cast<HTMLTextAreaElement*>(this)->updateValue();

In order to nuke "const" of "this".  This method is const and updateValue() is
not const.


More information about the webkit-reviews mailing list