[webkit-reviews] review denied: [Bug 29493] chromium layout test - button rendering : [Attachment 40025] basic button layout test patch - changed to have 4 space indents
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 23 16:16:47 PDT 2009
Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Karen
<karen+webkit at chromium.org>'s request for review:
Bug 29493: chromium layout test - button rendering
https://bugs.webkit.org/show_bug.cgi?id=29493
Attachment 40025: basic button layout test patch - changed to have 4 space
indents
https://bugs.webkit.org/attachment.cgi?id=40025&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> + return '<tr><td>' + (style || '(default)') + '</td>' +
> + '<td><button ' + (style ? 'style="' + style + '"' : '') + '>' + fooImage
+ '</button></td>' +
> + '<td></td>' +
> + '<td><input type="button" value="foo" style="' + style + '"></td>' +
> + '<td></td></tr>';
Extra 4 spaces. Sorry :)
More information about the webkit-reviews
mailing list