[webkit-reviews] review denied: [Bug 29348] [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally : [Attachment 40017] patch using proper signal emission technique

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 29348: [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
https://bugs.webkit.org/show_bug.cgi?id=29348

Attachment 40017: patch using proper signal emission technique
https://bugs.webkit.org/attachment.cgi?id=40017&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +	   void turnVerticalTicksIntoHorizontal()
> +	   {
> +	       m_deltaX += m_deltaY;
> +	       m_deltaY = 0;
> +
> +	       m_wheelTicksX += m_wheelTicksY;
> +	       m_wheelTicksY = 0;
> +	   }

I'm unhappy with this function, either it is dropping deltax entirely --
m_deltaX = m_deltaY -- or it is rotating the orientation 90 degrees, in which
case x and y delta, etc should be swapped.