[webkit-reviews] review denied: [Bug 29689] [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts : [Attachment 40012] Final patch, first attempt

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 29689: [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
https://bugs.webkit.org/show_bug.cgi?id=29689

Attachment 40012: Final patch, first attempt
https://bugs.webkit.org/attachment.cgi?id=40012&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +    FcFontSet* appFontSet = FcConfigGetFonts(0, FcSetApplication);
> +    if (appFontSet && numFonts >= 0 && appFontSet->nfont == numFonts)
> +	   return;

So, before reading the configuration this will return NULL or something? What
if the user has a configuration already at their home?

>  dumprendertree_cppflags += \
> -	-DTEST_PLUGIN_DIR=\"${shell
pwd}/${top_builddir}/TestNetscapePlugin/.libs\"
> +	-DTEST_PLUGIN_DIR=\"${shell
pwd}/${top_builddir}/TestNetscapePlugin/.libs\" \
> +	-DFONTS_CONF_FILE=\"${shell
pwd}/${srcdir}/WebKitTools/DumpRenderTree/qt/fonts.conf\"

I think we should have a copy of that configuration file in gtk/, instead of
refering from the qt one, to avoid being hit by any changes they need to do.

Did you test if render tree dumps are matching or more closely matching the
expected ones in Mac? =) I'll say r- till we get these two issues sorted out.