[webkit-reviews] review denied: [Bug 29653] [Qt] Qt-based browser fails to show the right language translation : [Attachment 39948] fix patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 29653: [Qt] Qt-based browser fails to show the right language translation
https://bugs.webkit.org/show_bug.cgi?id=29653

Attachment 39948: fix patch
https://bugs.webkit.org/attachment.cgi?id=39948&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You are correct.  Safari 4.0.3 on my Mac (SL) returns "en-us" but FF on the
same machine returns "en-US".  It seems we need to file a bug about Mac Safari,
I wonder if the casing could be a compat concern.

Please add a test which checks this.  Ideally a simple js-only test:
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree

shouldBe("navigator.language", "en-US");

which I suspect we'll have to skip on Mac.

I think that such a test should run fine on all localizations of OS X/Windows?
since I assume we override the language settings in DumpRenderTree, but maybe
my assumptions are wrong.

Either way, this change needs a test of some sort or an explanation why testing
is impossible/impractical.

Otherwise looks good!