[webkit-reviews] review denied: [Bug 26994] Store non-standard HTTP headers in history : [Attachment 40005] Patch #1 to resolve bug 26994.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Marshall Greenblatt
<magreenblatt at gmail.com>'s request for review:
Bug 26994: Store non-standard HTTP headers in history
https://bugs.webkit.org/show_bug.cgi?id=26994

Attachment 40005: Patch #1 to resolve bug 26994.
https://bugs.webkit.org/attachment.cgi?id=40005&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   if (it->first.find("X-") == 0)

This is not the correct way to check for a prefix. It wastefully searches the
entire string for "X-". There's a startsWith function that can be used for this
purpose. But also, should this be a case-sensitive check or case-insensitive?

Why keep the extra headers in a map instead of just in a vector of pairs? Do we
need efficient key lookup for some reason.

I don't understand the concept of this patch; why are headers the start with
"x-" different from others? I suspect this is the wrong approach.