[webkit-reviews] review denied: [Bug 29279] [Qt] Use rgb565 format for images on Symbian platform : [Attachment 39693] modified with coding style change

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at trolltech.com> has denied Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 29279: [Qt] Use rgb565 format for images on Symbian platform
https://bugs.webkit.org/show_bug.cgi?id=29279

Attachment 39693: modified with coding style change
https://bugs.webkit.org/attachment.cgi?id=39693&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at trolltech.com>

> +	   Images with no alpha channel will be converted to 16bit(rgb565)
format in Qt Symbian.
> +	   This reduces the memory footprint for displaying images.
> +	   https://bugs.webkit.org/show_bug.cgi?id=29279

Hardcoding the image format sounds like a wrong thing to do. What about having
a setting for that (QWebSettings)?

Also, what if the display depth is 24-bit or 32-bit? We save memory footprint
with the patch, but we slow down the painting (even without alpha-blending)
because of 16-to-32 pixel handling.