[webkit-reviews] review requested: [Bug 26342] Absolutely positioned HTML element within foreignObject of absolutely positioned SVG crashes Safari : [Attachment 39976] resubmit after adding comments and test case description change

[bugzilla-daemon at webkit.org]

Charles Wei <charles.wei at torchmobile.com.cn> has asked	for review:
Bug 26342: Absolutely positioned HTML element within foreignObject of
absolutely positioned SVG crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=26342

Attachment 39976: resubmit after adding comments and test case description
change
https://bugs.webkit.org/attachment.cgi?id=39976&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
1. Add change new-added member function isSVGForeignObject() from virtual
public to virtual private,  I don't in favor of that.  Please look at
RenderObject , it has similiar functions , like isSVGRoot(), isSVGContainer(),
isSVGText(), isSVGImage(), ... , all public virtual member functions.  I think
we should be consistent with all other similiar functions .

2. Test case descriptions changed as suggested by Eric

3. Comments added at o->isForeignObject()   to indicate foreignobject is the
containing block for its contents.