[webkit-reviews] review requested: [Bug 29660] Move "Generate 64-bit Export File" build phase script into DerivedSources.make : [Attachment 39960] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 22 16:33:54 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 29660: Move "Generate 64-bit Export File" build phase script into
DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=29660

Attachment 39960: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39960&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

The "Generate 64-bit Export File" build phase script built the
WebKit.LP64.exp export file used to link 64-bit WebKit.  Instead
of having a separate build phase script, move its generation
into DerivedSources.make where WebCore.exp is generated.  Note
that because of VPATH usage in DerivedSources.make
WebCore.LP64.exp had to be renamed to WebCore.LP64.base.exp.

* DerivedSources.make: Added a rule to make WebCore.LP64.exp.
* WebCore.LP64.base.exp: Renamed from WebCore/WebCore.LP64.exp.
* WebCore.xcodeproj/project.pbxproj: Removed the "Generate
64-bit Export File" build phase script.
---
 5 files changed, 44 insertions(+), 37 deletions(-)


More information about the webkit-reviews mailing list