[webkit-reviews] review granted: [Bug 29307] commit-queue needs web-based status reporting : [Attachment 39952] Unify ChangeLogs

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 29307: commit-queue needs web-based status reporting
https://bugs.webkit.org/show_bug.cgi?id=29307

Attachment 39952: Unify ChangeLogs
https://bugs.webkit.org/attachment.cgi?id=39952&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few nits to fix on landing.


> diff --git a/WebKitTools/CommitQueueStatus/filters/webkit_extras.py
b/WebKitTools/CommitQueueStatus/filters/webkit_extras.py
> +# Copyright (c) 2009, Google Inc. All rights reserved.

Ideally (C) and no comma after the year.

> +bug_regexp = re.compile("bug (?P<bug_id>\d+)")

Put r in front of the quotes. (Fortunately \d doesn't map to a string escape
but best to put use r"" for this anyway.)

> +patch_regexp = re.compile("patch (?P<patch_id>\d+)")

Put r in front of the quotes.

> +
> + at stringfilter
> +def webkit_linkify(value):
> +    value = bug_regexp.sub('<a href="http://webkit.org/b/\g<bug_id>">bug
\g<bug_id></a>', value)

Put r in front of the single quote (to make to clear that the \g isn't a string
escape).

> +    value = patch_regexp.sub('<a
href="https://bugs.webkit.org/attachment.cgi?id=\g<patch_id>&action=prettypatch
">patch \g<patch_id></a>', value)

Put r in front of the single quote.


> diff --git a/WebKitTools/CommitQueueStatus/queue_status.py
b/WebKitTools/CommitQueueStatus/queue_status.py
> +# Copyright (c) 2009, Google Inc. All rights reserved.

Ideally (C) and no comma after the year.


> diff --git a/WebKitTools/Scripts/modules/statusbot.py
b/WebKitTools/Scripts/modules/statusbot.py

> +# Copyright (c) 2009, Google Inc. All rights reserved.

Ideally (C) and no comma after the year.