[webkit-reviews] review requested: [Bug 29248] [Qt] [API] Make it possible to have 'invisible' loads : [Attachment 39950] patch 0.3 - make setHtml and setContent to not change history

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 22 15:09:21 PDT 2009


Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 29248: [Qt] [API] Make it possible to have 'invisible' loads
https://bugs.webkit.org/show_bug.cgi?id=29248

Attachment 39950: patch 0.3 - make setHtml and setContent to not change history
https://bugs.webkit.org/attachment.cgi?id=39950&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
as per API review on IRC, it was decided to make setHtml and setContent not to
change session and global history at all.

patch 0.3 implements so and adds an autotest that it by calling
qwebframe::setHtml in which an image is loaded (baseUrl used) and checks if
history has changed (page()->history()->count == 0).

patches for other features/improvements in followup bugs.


More information about the webkit-reviews mailing list