[webkit-reviews] review denied: [Bug 29651] [HTML5] Add a way for an application to register as a protocol handler. : [Attachment 39940] Proposed implementation of window.Navigator.registerProtocolHandler

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied B. Green <brg at chromium.org>'s
request for review:
Bug 29651: [HTML5] Add a way for an application to register as a protocol
handler.
https://bugs.webkit.org/show_bug.cgi?id=29651

Attachment 39940: Proposed implementation of
window.Navigator.registerProtocolHandler
https://bugs.webkit.org/attachment.cgi?id=39940&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Why does Chrome::runJavaScriptRegisterProtocolHandler return a boolean?

This code won't even compile.  Navigator::registerProtocolHandler calls a
non-existent method named "runJavascripRegisterProtocolHandler".

NAVIGATOR_ABILITIES is an incredibly vague name for a define and doesn't sound
at all related to the function in question.  It's not clear to me why this is
#if'd at all given that the default behavior is to do nothing.

We also prefer that a full name is used in ChangeLog entries.