[webkit-reviews] review denied: [Bug 29529] MathML Support for mover, munder, munderover, msubsup, and mfrac : [Attachment 39890] Fixed for style conformance and added pixel tests.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Alex Milowski <alex at milowski.com>'s
request for review:
Bug 29529: MathML Support for mover, munder, munderover, msubsup, and mfrac
https://bugs.webkit.org/show_bug.cgi?id=29529

Attachment 39890: Fixed for style conformance and added pixel tests.
https://bugs.webkit.org/attachment.cgi?id=39890&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Don't indent class headers.  I sent mail out to webkit-dev about this and
apologize for the style guide being wrong.

The code in RenderMathInlineContainer::setStyle is wrong.  You have lost any
non-inherited properties with the way you're doing that.   Typically when a
style needs to be adjusted we do this over in CSSStyleSelector's
adjustRenderStyle method.  I think SVG does some adjustments in its own adjust
method, so you may just want to do that over there.

You shouldn't have to set padding to 0 in makeBlockStyle.  Its default value is
0, and padding isn't inherited by default.  Same with margins.	The line-height
thing really confuses me. By forcing the line-height to be exactly the font's
height, you're not using the line-height that was built in to the font itself. 
Is that really what you want?

Similar questions in RenderMathSuperSub regarding why padding/margins are being
cleared out.