[webkit-reviews] review granted: [Bug 29644] [GTK] Add WEBKIT_LOAD_ERROR status : [Attachment 39926] loaderror.diff

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 29644: [GTK] Add WEBKIT_LOAD_ERROR status
https://bugs.webkit.org/show_bug.cgi?id=29644

Attachment 39926: loaderror.diff
https://bugs.webkit.org/attachment.cgi?id=39926&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #1)
> > > > Created an attachment (id=39926) [details] [details] [details]
[details]
> > > > loaderror.diff
> > > 
> > > Does this only appply to committed load errors?
> > 
> > Not really, when a URL does not exist we'll go from provisional to error
> > directly. Why?
> > 
> > BTW, I'm thinking that WEBKIT_LOAD_FAIL might be a better name than
> > WEBKIT_LOAD_ERROR, since the dispatch is called didFailLoad. Opinions? :)

I prefer LOAD_FAIL.

> On the other hand the existing signal is called 'load-error', hmmm... Naming
> things sucks.

Can we break API? Either way, r=me.