[webkit-reviews] review granted: [Bug 26342] Absolutely positioned HTML element within foreignObject of absolutely positioned SVG crashes Safari : [Attachment 39844] re-submission

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 26342: Absolutely positioned HTML element within foreignObject of
absolutely positioned SVG crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=26342

Attachment 39844: re-submission
https://bugs.webkit.org/attachment.cgi?id=39844&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    virtual bool isSVGForeignObject() const { return true; }

A function like this should be made private. If someone already has a
RenderForeignObject* it's a programming mistake for them to call
isSVGForeignObject and making it private will solve that problem.

Otherwise seems OK to make this change. I'll say r=me