[webkit-reviews] review requested: [Bug 29336] WebInspector.log() function not protected if console not yet created : [Attachment 39928] proposed patch - 2009/09/22

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 22 10:24:34 PDT 2009


Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 29336: WebInspector.log() function not protected if console not yet created
https://bugs.webkit.org/show_bug.cgi?id=29336

Attachment 39928: proposed patch - 2009/09/22
https://bugs.webkit.org/attachment.cgi?id=39928&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
issues resolved; split out the function into a number of inner functions for
reuse

ConsoleView changed recently so that it requires the messages being logged to
be proxy objects, so you'll see that I'm creating a proxy now for the message
passed into WebInspector.log() before sending it along to
WebInspector.ConsoleMessage()


More information about the webkit-reviews mailing list