[webkit-reviews] review denied: [Bug 29516] [Gtk] WebResource - initialize NULL-valued strings as a String : [Attachment 39814] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 21 22:25:48 PDT 2009


Xan Lopez <xan.lopez at gmail.com> has denied Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 29516: [Gtk] WebResource - initialize NULL-valued strings as a String
https://bugs.webkit.org/show_bug.cgi?id=29516

Attachment 39814: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39814&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
String::fromUTF8 already does this:

String String::fromUTF8(const char* string)
{
    if (!string)
	return String();
    return UTF8Encoding().decode(string, strlen(string));
}

Marking as r-.


More information about the webkit-reviews mailing list