[webkit-reviews] review denied: [Bug 29617] WebKit Chromium Port: Upstreaming gyp files into webkit : [Attachment 39885] Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 21 15:19:09 PDT 2009


David Levin <levin at chromium.org> has denied Yaar Schnitman
<yaar at chromium.org>'s request for review:
Bug 29617: WebKit Chromium Port: Upstreaming gyp files into webkit
https://bugs.webkit.org/show_bug.cgi?id=29617

Attachment 39885: Adds JavaScriptCore.gyp, WebCore.gyp and
chromium/features.gypi
https://bugs.webkit.org/attachment.cgi?id=39885&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Quick comments from a brief look:

The copyrights are not a correct format for WebKit.

"TODO(*):" should be "FIXME:"


More information about the webkit-reviews mailing list