[webkit-reviews] review granted: [Bug 29537] Web Inspector: Expose InspectorResource fields : [Attachment 39845] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 29537: Web Inspector: Expose InspectorResource fields
https://bugs.webkit.org/show_bug.cgi?id=29537

Attachment 39845: patch
https://bugs.webkit.org/attachment.cgi?id=39845&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> -
> -    if (!buffer)
> -	   return String();
> -
> -    TextEncoding encoding(textEncodingName);
> -    if (!encoding.isValid())
> -	   encoding = WindowsLatin1Encoding();
> -    return encoding.decode(buffer->data(), buffer->size());
>  }

I think an explicit return 0; would be good here, I think it happens anyway
because PassRefPtr is uesed, but I had to think about where there was no final
return here.