[webkit-reviews] review granted: [Bug 29605] [Chromium] Fix the V8 bindings' handling of window.top : [Attachment 39865] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 29605: [Chromium] Fix the V8 bindings' handling of window.top
https://bugs.webkit.org/show_bug.cgi?id=29605

Attachment 39865: patch
https://bugs.webkit.org/attachment.cgi?id=39865&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
We can't allow shadowing of window.top without confusing Flash and other
plug-ins.  The correct solution here is to convince the JSC port not to mark
|top| are replaceable, but that's a longer conversation.  In the meantime, we
should fix the LayoutTest.  If this regression is in stable, we should backport
this fix.

Thanks for the patch.