[webkit-reviews] review denied: [Bug 29250] Add nspluginwrapper plugins dir : [Attachment 39818] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 21 13:28:39 PDT 2009


Eric Seidel <eric at webkit.org> has denied Bastien Nocera <hadess at hadess.net>'s
request for review:
Bug 29250: Add nspluginwrapper plugins dir
https://bugs.webkit.org/show_bug.cgi?id=29250

Attachment 39818: updated patch
https://bugs.webkit.org/attachment.cgi?id=39818&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your ChangeLog has tabs.  That will fail to land due to our pre-commit hook
which looks for tabs.  Yes, we definitely should warn about this earlier than
during review.	(bug 29509).

Otherwise it looks sane enough to me.  I'll CC the linux chromium folks that
they might give more than just a rubber stamp (As they actually know something
about plugins on linux and I don't). :)

r- for the ChangeLog problem.  I would have r+'d this and you could fix it on
landing if you were a committer.


More information about the webkit-reviews mailing list