[webkit-reviews] review denied: [Bug 29290] StorageNamespace::storageArea() should take in a PassRefPtr<StorageOrigin> : [Attachment 39672] Patch v1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 29290: StorageNamespace::storageArea() should take in a
PassRefPtr<StorageOrigin>
https://bugs.webkit.org/show_bug.cgi?id=29290

Attachment 39672: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39672&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This code has some strange memory management.

Release is not needed here:
 113	 m_storageAreaMap.set(origin.release(), storageArea);

PassRefPtr's automatically release.

111112	   storageArea = adoptRef(new StorageAreaImpl(m_storageType, origin,
m_syncManager));
Really should be using a create() function instead.

I guess r- for the extra unneeded .release().  (Unless I'm misunderstanding
something?)