[webkit-reviews] review denied: [Bug 29004] [HTML5][Forms] simple implementation of date&time types of INPUT element : [Attachment 39343] Patch part2: ISO 8601 parser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 21 10:52:39 PDT 2009


Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 29004: [HTML5][Forms] simple implementation of date&time types of INPUT
element
https://bugs.webkit.org/show_bug.cgi?id=29004

Attachment 39343: Patch part2: ISO 8601 parser
https://bugs.webkit.org/attachment.cgi?id=39343&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You wrote the parser by yourself I assume?  It's no code from any other
license?

Also, we need tests for this parser.

I think we should consider splitting it off into its own file which DateMath
can use.  ISO8601DateParser or some other nicer name?

r- for the lack of tests.


More information about the webkit-reviews mailing list